Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] condainstall: Fix env for running conda #3843

Merged
merged 1 commit into from
May 31, 2019

Conversation

ales-erjavec
Copy link
Contributor

Issue

Fixes gh-3819

'CONDA_BAT' env variable is used by conda for running/activating scripts. Since conda 4.6.9, the use here breaks the subsequent post link scripts in package installs.

Description of changes

Move all the extra env modifications to the end of the script.

Includes
  • Code changes
  • Tests
  • Documentation

'CONDA_BAT' env variable is used by conda for running/activating scripts.
Since conda 4.6.9, the use here breaks the subsequent post link scripts in
package installs.

Fix by moving all the extra env modifications to the end of the script.
@ales-erjavec
Copy link
Contributor Author

Patched installer

@codecov
Copy link

codecov bot commented May 31, 2019

Codecov Report

Merging #3843 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3843      +/-   ##
==========================================
- Coverage   84.94%   84.94%   -0.01%     
==========================================
  Files         376      376              
  Lines       70159    70159              
==========================================
- Hits        59596    59594       -2     
- Misses      10563    10565       +2

@markotoplak markotoplak merged commit 2ce3a49 into biolab:master May 31, 2019
@ales-erjavec ales-erjavec deleted the fixes/conda-install-env branch March 16, 2020 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with miniconda installer 3.21.0
2 participants