-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Update output on new input, even if auto commit is disabled #3844
Conversation
d2a87d7
to
7045f54
Compare
7045f54
to
1bcc533
Compare
Codecov Report
@@ Coverage Diff @@
## master #3844 +/- ##
==========================================
+ Coverage 84.94% 84.95% +0.01%
==========================================
Files 376 376
Lines 70157 70220 +63
==========================================
+ Hits 59595 59657 +62
- Misses 10562 10563 +1 |
I yesterday assigned this to @ajdapretnar; for this one, maybe @VesnaT would have to check it, too. |
I think considering this PR is dealing with apply, it would be nice if it fixed the mismatching buttons in Color and Concatenate, which are unlike those of other widgets. |
This is one of supported generic options. It is more obvious than the usual (checkbox without a label) but we seldom use it because most widgets are not wide enough. I can of course remove it (the label is set by an explicit argument to |
All widgets in this PR works correctly now, so I will merge it. With this PR debate about the inconsistency of auto-commit button started. I will open the separate issue to continue it. |
Issue
Fixes #3761.
Description of changes
Call
unconditional_apply
instead ofapply
; remove the pointless auto commit checkbox in box plot.Includes