[ENH] Mosaic: Wrap legend #3866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janezd
force-pushed
the
owmosaic-wrap-legend
branch
from
6ba3a48
to
1098e8d
Compare
Codecov Report
@@ Coverage Diff @@
## master #3866 +/- ##
==========================================
- Coverage 84.97% 84.96% -0.01%
==========================================
Files 378 378
Lines 70496 70520 +24
==========================================
+ Hits 59905 59920 +15
- Misses 10591 10600 +9 |
janezd
force-pushed
the
owmosaic-wrap-legend
branch
from
1098e8d
to
d23b8ac
Compare
janezd
force-pushed
the
owmosaic-wrap-legend
branch
from
d23b8ac
to
d8f6cf6
Compare
janezd
force-pushed
the
owmosaic-wrap-legend
branch
from
d8f6cf6
to
96361c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #3052.
The function for wrapping the legend is put into module
plotutil, so it can also be used elsewhere.TODO: When decreasing the widget height, the legend can fall out of view at the bottom, despite my attempts to correctly compute the maximal square size.Includes