Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Change normalization to Scaling in SVM #3898

Merged
merged 6 commits into from
Jul 29, 2019

Conversation

AndrejaKovacic
Copy link
Contributor

Issue

Fixes #3202

Description of changes

SVM was failing because Corpus widget outputs sparse matrix which must be then turned to dense, if we want to mean shift it. We would like to avoid that, so the current proposal is to just scale the data. The user can opt out trough a check box. Currently the check box is in the optimization parameters box, perhaps something else is needed.

Includes
  • Code changes
  • Tests
  • Documentation

Copy link
Contributor

@thocevar thocevar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user can opt out trough a check box. Currently the check box is in the optimization parameters box, perhaps something else is needed.

I don't see this check box.

Orange/preprocess/preprocess.py Outdated Show resolved Hide resolved
Orange/preprocess/preprocess.py Outdated Show resolved Hide resolved
Orange/preprocess/preprocess.py Outdated Show resolved Hide resolved
Orange/preprocess/preprocess.py Outdated Show resolved Hide resolved
Orange/widgets/model/owsvm.py Outdated Show resolved Hide resolved
Orange/widgets/model/tests/test_owsvm.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 26, 2019

Codecov Report

Merging #3898 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3898      +/-   ##
==========================================
+ Coverage   85.02%   85.02%   +<.01%     
==========================================
  Files         378      378              
  Lines       66679    66705      +26     
==========================================
+ Hits        56691    56715      +24     
- Misses       9988     9990       +2

@codecov
Copy link

codecov bot commented Jul 26, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@37e7b02). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #3898   +/-   ##
=========================================
  Coverage          ?   84.84%           
=========================================
  Files             ?      371           
  Lines             ?    65514           
  Branches          ?        0           
=========================================
  Hits              ?    55588           
  Misses            ?     9926           
  Partials          ?        0

@thocevar thocevar merged commit 030f769 into biolab:master Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SVM fails when mixing original and BoW attributes
2 participants