Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fix storing and retrieving selection, and unconditional auto commit #3957

Merged
merged 10 commits into from
Sep 20, 2019

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Aug 1, 2019

Fixes #3762. Fixes #3763.

Following @markotoplak suggestion, instance selections are schema-only because data is not a part of the context.

@codecov
Copy link

codecov bot commented Aug 1, 2019

Codecov Report

Merging #3957 into master will increase coverage by 0.05%.
The diff coverage is 99.31%.

@@            Coverage Diff             @@
##           master    #3957      +/-   ##
==========================================
+ Coverage   85.42%   85.47%   +0.05%     
==========================================
  Files         385      385              
  Lines       68873    69007     +134     
==========================================
+ Hits        58832    58986     +154     
+ Misses      10041    10021      -20

@janezd janezd force-pushed the retain-selection branch from 21e7f57 to 6dddb3b Compare August 1, 2019 15:26
@janezd janezd changed the title [FIX] Retain selection in Silhouette plot, Mosaic and Distance Map [FIX] Fix storing and retrieving selection, and unconditional auto commit Aug 1, 2019
@janezd janezd force-pushed the retain-selection branch 3 times, most recently from 2dc4f0e to 9145e74 Compare August 1, 2019 21:16
@janezd
Copy link
Contributor Author

janezd commented Aug 30, 2019

On Travis on Python 3.7 this consistently inconsistently core dumps in Relief, which should be unrelated to these changes. Help!

@janezd janezd assigned VesnaT and unassigned ajdapretnar Sep 13, 2019
@@ -442,6 +443,7 @@ def set_data(self, data):

self.init_combos(self.data)
self.openContext(self.data)
self.__pending_selection = self.selection
Copy link
Contributor

@VesnaT VesnaT Sep 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be a 'schema only' setting?

@@ -76,6 +76,8 @@ class Outputs:
add_scores = settings.Setting(False)
auto_commit = settings.Setting(True)

pending_selection = settings.ContextSetting(None, schema_only=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have not handled 'schema only' context settings, so setting the flag to True has no effect.

@janezd janezd force-pushed the retain-selection branch 3 times, most recently from 1dc4880 to fc22065 Compare September 13, 2019 16:48
self.set_color_data()
self.reset_graph()
self.update_graph()
self.send_selection()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VesnaT, copying from projection widget indeed helped (and you were right about not using pack_settings, I should have listened more carefully and be less self confident :)).

However, every widget has also its own tricks, so you can't just copy. In this case, it was important to call send_selection after update_graph.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants