Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Correlations: Add progress bar, retain responsiveness #4011

Merged
merged 3 commits into from
Sep 13, 2019

Conversation

VesnaT
Copy link
Contributor

@VesnaT VesnaT commented Sep 6, 2019

Issue

Fixes #4008

Since adding the progress bar was somehow trivial, making the widget responsive was not and I'm still not sure about the solution.

The widget was getting unresponsive for datasets with small number of instances and many features. In those cases correlation between a pair of features was calculated 'too fast' which caused a signal, for setting partial results, being emitted too frequently. Consequently the widget was getting unresponsive.

Description of changes

To prevent the congestion, the signal is only emitted every 0.01 second.

Includes
  • Code changes
  • Tests
  • Documentation

@VesnaT VesnaT force-pushed the correlations_progress_bar branch 2 times, most recently from 0fa9a8b to a8a6c7f Compare September 9, 2019 08:24
@codecov
Copy link

codecov bot commented Sep 9, 2019

Codecov Report

Merging #4011 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4011      +/-   ##
==========================================
+ Coverage   85.38%   85.39%   +<.01%     
==========================================
  Files         385      385              
  Lines       68659    68710      +51     
==========================================
+ Hits        58625    58675      +50     
- Misses      10034    10035       +1

@VesnaT VesnaT changed the title Correlations: Add progress bar [WIP] Correlations: Add progress bar Sep 10, 2019
@VesnaT VesnaT force-pushed the correlations_progress_bar branch from 18c4570 to 3619455 Compare September 10, 2019 10:26
@VesnaT VesnaT changed the title [WIP] Correlations: Add progress bar [FIX] Correlations: Add progress bar Sep 11, 2019
@VesnaT VesnaT changed the title [FIX] Correlations: Add progress bar [FIX] Correlations: Add progress bar, retain responsiveness Sep 11, 2019
@VesnaT VesnaT force-pushed the correlations_progress_bar branch from b5aa2a2 to d69bdd2 Compare September 11, 2019 09:09
@VesnaT VesnaT force-pushed the correlations_progress_bar branch from d69bdd2 to 7a52bc6 Compare September 11, 2019 09:23
@ales-erjavec ales-erjavec merged commit c5d8f21 into biolab:master Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correlations makes Orange unresponsive
2 participants