Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] OWBaseSql: Base widget for connecting to a database #4083

Merged
merged 1 commit into from
Oct 18, 2019

Conversation

VesnaT
Copy link
Contributor

@VesnaT VesnaT commented Oct 7, 2019

Issue

Some add-ons require a widget to connect to a database.
To avoid copying the code over and over again, create a base widget that holds the common code for the DB connection.

Description of changes
  • a base widget to establish a DB connection
  • refactor OWSQL so it extends OWBaseSql (TODO: in next PR)
Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Oct 7, 2019

Codecov Report

Merging #4083 into master will increase coverage by 0.03%.
The diff coverage is 98.9%.

@@            Coverage Diff             @@
##           master    #4083      +/-   ##
==========================================
+ Coverage   85.58%   85.62%   +0.03%     
==========================================
  Files         385      387       +2     
  Lines       69228    69410     +182     
==========================================
+ Hits        59249    59429     +180     
- Misses       9979     9981       +2

@VesnaT VesnaT force-pushed the base_sql branch 2 times, most recently from 47dd8bf to 08279ab Compare October 10, 2019 05:20
@VesnaT VesnaT force-pushed the base_sql branch 5 times, most recently from 781149e to 7356d6e Compare October 16, 2019 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants