Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] k-Means: Add normalization checkbox #4099

Merged
merged 1 commit into from
Oct 11, 2019

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Oct 11, 2019

Issue

Fixes #4075.

Description of changes
  • Add normalization checkbox.
  • Fix tests
  • Remove obsolete argument processEvents
Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Oct 11, 2019

Codecov Report

Merging #4099 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4099      +/-   ##
==========================================
- Coverage   85.56%   85.56%   -0.01%     
==========================================
  Files         385      385              
  Lines       69220    69232      +12     
==========================================
+ Hits        59231    59240       +9     
- Misses       9989     9992       +3

self.send_signal(self.widget.Inputs.data, Table("housing"), wait=5000)
self.commit_and_wait()
widget.update_results()
# for housing dataset without normalization,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without -> with ?

@lanzagar lanzagar changed the title OWKMeans: Add normalization checkbox [ENH] k-Means: Add normalization checkbox Oct 11, 2019
@lanzagar lanzagar merged commit 858113f into biolab:master Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

k-Means widget does not normalize numeric features
2 participants