Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Scatterplot: Disable vizrank when features on input #4102

Merged
merged 2 commits into from
Oct 14, 2019

Conversation

VesnaT
Copy link
Contributor

@VesnaT VesnaT commented Oct 14, 2019

Issue

Feature selection is enabled, even though features are passed to the input of Scatterplot.
To reproduce: File (Iris) -> Scatterplot
-> Correlations -> Scatterplot -> Axis x, Axis y and Find Informative Projections are enabled

Similar to #4101.

Description of changes
  • disable table and button on vizrank popup when features are not the input of the widget
  • disable attr_x and attr_y selection when features are not the input of the widget
  • initialize vizrank only when data (input) changes, not features
Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Oct 14, 2019

Codecov Report

Merging #4102 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4102      +/-   ##
==========================================
+ Coverage   85.56%   85.57%   +<.01%     
==========================================
  Files         385      385              
  Lines       69201    69215      +14     
==========================================
+ Hits        59211    59229      +18     
+ Misses       9990     9986       -4

@VesnaT VesnaT changed the title Scatterplot: Disable vizrank when features on input [FIX] Scatterplot: Disable vizrank when features on input Oct 14, 2019
@janezd janezd merged commit 11b4b3f into biolab:master Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants