Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] macOS: Installer python version #4130

Merged
merged 8 commits into from
Nov 8, 2019

Conversation

ales-erjavec
Copy link
Contributor

Issue

Add support for 3.7 and 3.8 python in the macOS application bundle.

Description of changes

Extend installer build scripts

  • Add support for 10.9 target macOS target version, (also allow pre-release versions for testing)
  • Use Python 3.7.5 (macOs 10.9 target) by default.
Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Oct 22, 2019

Codecov Report

Merging #4130 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4130      +/-   ##
==========================================
- Coverage   85.68%   85.67%   -0.01%     
==========================================
  Files         390      390              
  Lines       69732    69732              
==========================================
- Hits        59750    59746       -4     
- Misses       9982     9986       +4

@astaric
Copy link
Member

astaric commented Oct 24, 2019

Tried to test this. When I run

./build-macos-app.sh ~/tmp/orange3-test

on Catalina, I get

curl: (22) The requested URL returned error: 404 
tar: Python_Framework.pkg/Payload: Not found in archive
tar: Error exit delayed from previous errors.
Single version framework expected (found: )
./python-framework.sh: line 298: cd: /Users/anze/tmp/orange3-test/Contents/Frameworks/Python.framework/Versions: No such file or directory
./python-framework.sh: line 300: no match: ?.?
./python-framework.sh: line 250: /Users/anze/tmp/orange3-test/Contents/Frameworks/Python.framework/Versions/Current/bin/python?.?: No such file or directory
./python-framework.sh: line 251: /Users/anze/tmp/orange3-test/Contents/Frameworks/Python.framework/Versions/Current/bin/python?.?: No such file or directory

@astaric
Copy link
Member

astaric commented Oct 24, 2019

Error changed to

tar: Error opening archive: Unrecognized archive format
Single version framework expected (found: )
./python-framework.sh: line 302: no match: ?.?
./python-framework.sh: line 252: /Users/anze/tmp/orange3-test/Contents/Frameworks/Python.framework/Versions/Current/bin/python?.?: No such file or directory
./python-framework.sh: line 253: /Users/anze/tmp/orange3-test/Contents/Frameworks/Python.framework/Versions/Current/bin/python?.?: No such file or directory

I get the same error if I run tar -xf /Users/anze/.cache/pkgs/python-3.7.5-macosx10.9.pkg
The archive seems ok, since I can run xar -xf /Users/anze/.cache/pkgs/python-3.7.5-macosx10.9.pk just fine.

Edit: Tried on a clean install of Catalina to rule out OS problems, same error.

@astaric
Copy link
Member

astaric commented Oct 30, 2019

Python installation now works, but installer building still errors with

  ERROR: Could not find a version that satisfies the requirement sip==4.19.3 (from -r ./requirements.txt (line 19)) (from versions: 4.19.7, 4.19.8, 5.0.0)
ERROR: No matching distribution found for sip==4.19.3 (from -r ./requirements.txt (line 19))

(sip 4.19.3 has not been built for python 3.7)

@janezd janezd merged commit 0984ac6 into biolab:master Nov 8, 2019
@ales-erjavec ales-erjavec deleted the macos-installer-python-version branch March 16, 2020 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants