[FIX] ROC and LiftCurve: Store context settings #4138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4138 +/- ##
=========================================
Coverage ? 85.67%
=========================================
Files ? 389
Lines ? 69677
Branches ? 0
=========================================
Hits ? 59694
Misses ? 9983
Partials ? 0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #4115: Lift curve and ROC Analysis did not have context settings. (Also because there was no suitable handler before #3881; #3881 implemented such a handler for the new calibration plot widget and even noticed that Lift Curve and ROC Analysis can now use it :).
Description of changes
Use
EvaluationResultsContextHandlerin the two widgets.Includes