Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Heatmap: Allow labeling by any variable #4209

Merged
merged 1 commit into from
Nov 22, 2019

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Nov 22, 2019

Issue

Fixes #4206.

Description of changes
  • Switch do using DomainModel to get everything for free.
  • Store the annotation variable as an instance of Variable instead of integer indices into domain.
  • Use the original domain and not just the numeric features for context!

Settings cannot be migrated because they were broken. The annotation variable was stored as an index into the original domain, while context was stored based on filtered domain. The two could mismatch and settings could have been stored incorrectly, so they can't be safely migrated.

Includes
  • Code changes
  • Tests
  • Documentation

@janezd janezd requested a review from ajdapretnar November 22, 2019 09:20
@janezd janezd changed the title [ENH] Heatmap: Allow mapping by any variable [ENH] Heatmap: Allow labeling by any variable Nov 22, 2019
@codecov
Copy link

codecov bot commented Nov 22, 2019

Codecov Report

Merging #4209 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4209      +/-   ##
==========================================
+ Coverage   85.95%   85.95%   +<.01%     
==========================================
  Files         394      394              
  Lines       70153    70145       -8     
==========================================
- Hits        60302    60296       -6     
+ Misses       9851     9849       -2

@ajdapretnar ajdapretnar merged commit 40808f4 into biolab:master Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OWHeatMap: enable labeling by any variable
2 participants