Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] File widget: fix name change #4235

Merged
merged 1 commit into from
Nov 29, 2019

Conversation

PrimozGodec
Copy link
Contributor

Issue

File widget fails on an attribute name change. It happens just in cases when only the name is changed and the type of variable stays the same.

Description of changes

Fixed name change using the copy function. It seems that the variable name is protected (no setter function).

Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Nov 28, 2019

Codecov Report

Merging #4235 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4235      +/-   ##
==========================================
+ Coverage   86.03%   86.04%   +0.01%     
==========================================
  Files         394      394              
  Lines       70169    70200      +31     
==========================================
+ Hits        60369    60404      +35     
+ Misses       9800     9796       -4

@PrimozGodec PrimozGodec changed the title File: fix name change [FIX] File widget: fix name change Nov 28, 2019
@janezd janezd self-assigned this Nov 29, 2019
@janezd janezd changed the title [FIX] File widget: fix name change [WIP] [FIX] File widget: fix name change Nov 29, 2019
@PrimozGodec PrimozGodec force-pushed the enable-var-name-change branch from 1204e92 to 82f1032 Compare November 29, 2019 13:33
@PrimozGodec PrimozGodec changed the title [WIP] [FIX] File widget: fix name change [FIX] File widget: fix name change Nov 29, 2019
@PrimozGodec
Copy link
Contributor Author

@janezd it is ready now.

@janezd janezd merged commit bc08b7f into biolab:master Nov 29, 2019
@PrimozGodec PrimozGodec deleted the enable-var-name-change branch December 2, 2019 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants