Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] PCA: Add a signal with original data + pca #4255

Merged
merged 1 commit into from
Dec 13, 2019

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Dec 6, 2019

Issue

Closes #3801.

Description of changes

To maintain backward compatibility, this adds a new signal instead of adding the original data as metas (ugly, not done in other widgets) or moving components to metas (incompatible).

Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Dec 6, 2019

Codecov Report

Merging #4255 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #4255      +/-   ##
=========================================
+ Coverage    86.2%   86.2%   +<.01%     
=========================================
  Files         396     396              
  Lines       70437   70460      +23     
=========================================
+ Hits        60718   60738      +20     
- Misses       9719    9722       +3

@janezd janezd changed the title PCA: Add a signal with original data + pca [ENH] PCA: Add a signal with original data + pca Dec 6, 2019
@janezd janezd force-pushed the pca-original-data branch from 7d680c7 to a89c640 Compare December 6, 2019 18:15
@janezd janezd assigned ajdapretnar and BlazZupan and unassigned ajdapretnar Dec 12, 2019
@BlazZupan
Copy link
Contributor

Nice, separation of the signals and including principal components as meta features is a nice idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PCA: retain all data (Unification of embedding methods )
3 participants