Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] owcsvimport: Fix last/recent item serialization #4272

Merged
merged 3 commits into from
Dec 20, 2019

Conversation

ales-erjavec
Copy link
Contributor

Issue

'CSV Import' does not store the current file/options in a workflow scheme if the current file is not explicitly selected after the widget is placed in the workflow.

Steps to reproduce
  1. Place the widget on the workflow and let it load the last loaded file (do not change anything), save the workflow.
  2. Create a new workflow and add the 'CSV Import' widget, select a different file to load.
  3. Reload the workflow from step 1. The widget will load the file from the second step.

Selecting a different file in step 1 would correctly store the item.

Description of changes

Call set_current_file in __init__ to record the initial loaded file in the scheme_only recorded _session_items.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Dec 17, 2019

Codecov Report

Merging #4272 into master will increase coverage by 0.25%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4272      +/-   ##
==========================================
+ Coverage   86.22%   86.47%   +0.25%     
==========================================
  Files         396      396              
  Lines       70706    70748      +42     
==========================================
+ Hits        60964    61181     +217     
+ Misses       9742     9567     -175

@janezd janezd self-assigned this Dec 19, 2019
@janezd janezd merged commit 8e88469 into biolab:master Dec 20, 2019
@ales-erjavec ales-erjavec deleted the fixes/owcsvimport-current-init branch March 16, 2020 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants