Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] ExcelReader: Migrate to openpyxl #4279

Merged
merged 2 commits into from
Dec 20, 2019
Merged

Conversation

VesnaT
Copy link
Contributor

@VesnaT VesnaT commented Dec 19, 2019

Issue

Fixes #2539

Description of changes

Introduce separate Excel files readers:

  • ExcelReader: for reading .xlsx using openpyxl
  • XlsReader: for reading .xls using xlrd
Includes
  • Code changes
  • Tests
  • Documentation

@VesnaT VesnaT force-pushed the xlsx_reader branch 3 times, most recently from d4bfbb3 to a0c1d41 Compare December 19, 2019 11:29
@codecov
Copy link

codecov bot commented Dec 19, 2019

Codecov Report

Merging #4279 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4279      +/-   ##
==========================================
- Coverage   86.24%   86.22%   -0.02%     
==========================================
  Files         396      396              
  Lines       70714    70737      +23     
==========================================
+ Hits        60989    60996       +7     
- Misses       9725     9741      +16

@janezd janezd self-assigned this Dec 19, 2019
@janezd
Copy link
Contributor

janezd commented Dec 20, 2019

If we knew this was so simple, we wouldn't wait for 2.5 years. The problem was reported in Orange 3.5. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ExcelReader: handle round (integer) floating-point values
2 participants