[ENH] clustering/hierarchical: Use optimal_leaf_ordering from scipy #4288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ales-erjavec
force-pushed
the
hierarchical-opt-leaf-order-scipy
branch
from
55c8bfd
to
380fff9
Compare
Codecov Report
@@ Coverage Diff @@
## master #4288 +/- ##
==========================================
+ Coverage 86.68% 86.71% +0.02%
==========================================
Files 396 396
Lines 71510 71393 -117
==========================================
- Hits 61988 61906 -82
+ Misses 9522 9487 -35 |
ajdapretnar
approved these changes
Dec 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Scipy >= 1.0.0 has a compiled optimal_leaf_ordering implementation that can be used instead of the implementation here.
Description of changes
scipy.cluster.hierarchical.optimal_leaf_orderinginstead of the implementation contained here.Includes