[ENH] Allow add-ons to register file format for the Save widget #4302
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #3701.
Description of changes
The first commit replaces class attribute
filters
ofOWSaveBase
with a class methodget_filters
to allow derived classes to create the list dynamically. Class attributefilters
still exists and the providedget_filters
returns it; this is to ensure the backward compatibility. Makingfilters
a property instead of creating a method is not a good alternative:filters
is used in some class methods that cannot be easily changed into ordinary methods (i.e. methods of classes that implement platform-specific dialogs). Thusfilter
would have to be a class property, but class properties are messy hacks (unless we want to have a meta class forOWSaveBase
).The second commit implements
get_methods
forOWSave
.Includes