-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Reorganize continuous palettes #4305
Conversation
6bd9abd
to
78a57d5
Compare
This looks much better than before. +1 for the PR! |
2 bugs.
|
cbe2051
to
e21cde0
Compare
Codecov Report
@@ Coverage Diff @@
## master #4305 +/- ##
==========================================
+ Coverage 87.19% 87.43% +0.24%
==========================================
Files 401 405 +4
Lines 72938 74061 +1123
==========================================
+ Hits 63595 64757 +1162
+ Misses 9343 9304 -39 |
dfc97b1
to
58d4ed2
Compare
Issues:
Don't honestly know what to check in Paint Data, Calibration Plot, Lift Curve and ROC Analysis. Or Venn Diagram. |
I don't see how this could happen. Did you discover this in scatter plot (or some other projection)? I was able to replicate this on master. The problem is in scatter plot -- if you disconnect and reconnect it, the colors are OK. I reported this in #4391.
Suggestions? Should Distance map (and similar widgets) be aware of palettes and pick different colors for showing selections? Palette classes could include information about which color is "distinguishable" from those in the palette. Should we do this?
Just that they work. They use new palettes now, but just for getting a list of colors. Not much to go wrong there. |
5ba56e7
to
5c17c85
Compare
I fixed problems found by @ajdapretnar, except for choosing a better color for marking selections, which we have to discuss. @ajdapretnar, I updated documentation, except images. I'm attaching a colorful screenshot of a widget. I haven't prepared screenshot with workflow and widgets (because shadows and background...). @ajdapretnar, could you? For numeric variables, consider "rainbow". If you like it -- if you don't, don't. |
As for selections, we can address this in another PR I suppose. |
I have pushed two commits to your branch. They add the documentation and a sorry attempt at tricking the build script to ignore explicitly unindexed images. I do not know anything about bash, so... 🤷♀ It should probably work, but who knows. |
c5181e4
to
bee3df1
Compare
66961cc
to
e5b6949
Compare
Issue
Fixes #1924
Description of changes
To fix:
To consider for the future (rather than here):
Scale
and some other methods fromowscatterplotgraph
and possiblyowsom
to some utils module so they can be shared with other widgets.Includes