Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] owhierarchicalclustering: Prescale dendrogram geometry #4322

Merged
merged 2 commits into from
Jan 14, 2020

Conversation

ales-erjavec
Copy link
Contributor

Issue

Fixes gh-2650

Description of changes
  • Prescale the dendrogram geometry to a fixed range to avoid fuzzy comparisons in QPainterPath, ...
Includes
  • Code changes
  • Tests
  • Documentation

@ales-erjavec ales-erjavec changed the title [FIX] owhierclustering: Prescale dendrogram geometry [FIX] owhierarchicalclustering: Prescale dendrogram geometry Jan 10, 2020
@codecov
Copy link

codecov bot commented Jan 10, 2020

Codecov Report

Merging #4322 into master will increase coverage by 0.06%.
The diff coverage is 98.61%.

@@            Coverage Diff             @@
##           master    #4322      +/-   ##
==========================================
+ Coverage   86.77%   86.83%   +0.06%     
==========================================
  Files         396      396              
  Lines       71550    71759     +209     
==========================================
+ Hits        62089    62315     +226     
+ Misses       9461     9444      -17

@PrimozGodec
Copy link
Contributor

Thanks @ales-erjavec it looks good.

@PrimozGodec PrimozGodec merged commit 9affca9 into biolab:master Jan 14, 2020
@ales-erjavec ales-erjavec deleted the owhierclust-prescale-height branch March 16, 2020 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hierarchical Clustering: Buggy visualization
2 participants