Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC][ENH] Outliers: Widget upgrade #4338

Merged
merged 10 commits into from
Jan 24, 2020
Merged

Conversation

VesnaT
Copy link
Contributor

@VesnaT VesnaT commented Jan 16, 2020

Issue

Current Outlier widget usually does not find desired amount of outliers.

Description of changes
  • wrap sklearn classes for outlier detection (LocalOutlierFactor , IsolationForest)
  • introduce separate editors for each outlier detector
  • output annotated data (appended Outlier feature)
Things to discuss
  • the widget could accept distance matrix and use it for LocalOutlierFactor
  • custom method (identify outliers using distance from the mean (threshold could be some multiple of std) for each feature)
  • responsive widget: the widget could make calculations in a separate thread to make Orange responsive, but it is impossible to terminate the calculation. The progress could be shown only during preprocessing, before fitting, after fitting, after predicting and during output construction.
  • save fitted model into annotated data (Outlier feature's computed value) for novelty detection using apply domain widget
Includes
  • Code changes
  • Tests
  • Documentation

@VesnaT VesnaT changed the title [ENH] Outliers: Widget upgrade [RFC][ENH] Outliers: Widget upgrade Jan 16, 2020
@VesnaT VesnaT force-pushed the outlier_detection branch from 0ad8b3a to 11cfb20 Compare January 16, 2020 14:44
@VesnaT VesnaT force-pushed the outlier_detection branch from 11cfb20 to 45ef64b Compare January 16, 2020 15:00
@codecov
Copy link

codecov bot commented Jan 16, 2020

Codecov Report

Merging #4338 into master will increase coverage by 0.07%.
The diff coverage is 98.85%.

@@            Coverage Diff             @@
##           master    #4338      +/-   ##
==========================================
+ Coverage   86.84%   86.91%   +0.07%     
==========================================
  Files         396      396              
  Lines       71782    71975     +193     
==========================================
+ Hits        62338    62557     +219     
+ Misses       9444     9418      -26

@VesnaT VesnaT force-pushed the outlier_detection branch from 45ef64b to 5405402 Compare January 16, 2020 21:41
@VesnaT VesnaT force-pushed the outlier_detection branch from 5405402 to 40f5521 Compare January 17, 2020 06:33
@BlazZupan BlazZupan merged commit 4256b16 into biolab:master Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants