[FIX] DendrogramWidget: Remove event filters before removing items #4361
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fix what appears to be a quadratic time bottleneck in
DendrogramWidget.clear
Alleviates gh-2663
Description of changes
Each
removeItem
seems to be linear in number of installed filters in the whole scene -> so this would be quadratic for us (not accounting any other filters not part ofDendrogramWidget
).Includes