Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Outliers: Save model into compute_value #4372

Merged
merged 3 commits into from
Jan 31, 2020

Conversation

VesnaT
Copy link
Contributor

@VesnaT VesnaT commented Jan 28, 2020

Issue

Outlier widget could be used for novelty detection using the Apply Domain widget.

Description of changes
  • invoking model's call operator now returns original dataset, appended an Outlier meta variable
  • save fitted model into the Outlier variable compute_value
  • the data output of Outliers widget can be used as a template data for Apply Domain widget
  • fix EllipticEnvelopeClassifier for dataset with missing values
Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Jan 28, 2020

Codecov Report

Merging #4372 into master will increase coverage by <.01%.
The diff coverage is 95.15%.

@@            Coverage Diff             @@
##           master    #4372      +/-   ##
==========================================
+ Coverage   87.13%   87.13%   +<.01%     
==========================================
  Files         399      399              
  Lines       72901    72960      +59     
==========================================
+ Hits        63521    63577      +56     
- Misses       9380     9383       +3

@VesnaT VesnaT force-pushed the outliers_apply_domain branch from 7e2f561 to 4873747 Compare January 29, 2020 06:58
@VesnaT VesnaT force-pushed the outliers_apply_domain branch from 4873747 to 16cac60 Compare January 29, 2020 09:10
@PrimozGodec PrimozGodec merged commit 486f8f6 into biolab:master Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants