Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Heatmap: Tighter layout #4390

Merged
merged 6 commits into from
Feb 14, 2020

Conversation

ales-erjavec
Copy link
Contributor

Issue

Ref gh-4380

Description of changes
  • Improve size hinting
  • Move 'Split by' labels/titles (when in effect) to the left of the heatmaps/dendrogram.
  • Decrease spacing between consecutive heatmap parts when split
  • Fix an error in 'resetting' fixed row size constraints which could cause QGraphicsGridLayout to enter an endless loop.
Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Jan 31, 2020

Codecov Report

Merging #4390 into master will increase coverage by <.01%.
The diff coverage is 89.47%.

@@            Coverage Diff             @@
##           master    #4390      +/-   ##
==========================================
+ Coverage   87.18%   87.19%   +<.01%     
==========================================
  Files         401      401              
  Lines       72938    72934       -4     
==========================================
  Hits        63592    63592              
+ Misses       9346     9342       -4

@ales-erjavec ales-erjavec force-pushed the heatmap-layout-aspect branch from c80b864 to a63c8c1 Compare February 4, 2020 10:19
@BlazZupan BlazZupan merged commit 9a4da3d into biolab:master Feb 14, 2020
@ales-erjavec ales-erjavec deleted the heatmap-layout-aspect branch March 16, 2020 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants