[FIX] Fix missing values after purging unused values #4432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janezd
changed the title
janezd
force-pushed
the
select-rows-nan-class
branch
from
168ddf0 to
fd0c090
Compare
Codecov Report
@@ Coverage Diff @@
## master #4432 +/- ##
=======================================
Coverage 87.47% 87.47%
=======================================
Files 405 405
Lines 74135 74148 +13
=======================================
+ Hits 64846 64862 +16
+ Misses 9289 9286 -3 |
janezd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #4416.
When removing
Variable.make, I assumed that we no longer neededLookupinremove_unused_valuesbecause values are mapped anyway. This doesn't work when the variable that is being purged hascompute_valuedefined, for instance if the variable is a discretized version of some numeric variable.Description of changes
Re-add lookup.
Although the bug was in remover, I also kept the test in
test_owselectrows, where we detected the problem.Includes