Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add row side color annotations #4443

Merged
merged 31 commits into from
Mar 7, 2020

Conversation

ales-erjavec
Copy link
Contributor

Issue

Ref gh-4380

Add color row annotations to the 'Heatmap' widget.

Description of changes
  • Refactor the OWHeatmap widget:
    • Move the implementation of the QGraphicsWidget and layouting into separate module.
Includes
  • Code changes
  • Tests
  • Documentation

@ales-erjavec ales-erjavec force-pushed the heatmaps-grid-widget branch 2 times, most recently from a8e38fd to b339c5d Compare February 21, 2020 10:53
@codecov
Copy link

codecov bot commented Feb 24, 2020

Codecov Report

Merging #4443 into master will increase coverage by 0.11%.
The diff coverage is 79.08%.

@@            Coverage Diff             @@
##           master    #4443      +/-   ##
==========================================
+ Coverage   83.13%   83.24%   +0.11%     
==========================================
  Files         268      274       +6     
  Lines       53916    54807     +891     
==========================================
+ Hits        44821    45625     +804     
- Misses       9095     9182      +87

@ales-erjavec ales-erjavec force-pushed the heatmaps-grid-widget branch 6 times, most recently from f60ee58 to d1c5962 Compare February 27, 2020 10:19
@Hrovatin
Copy link
Contributor

  • There is an issue with row text annotations that sometimes overlap/are only partially shown (when keep aspect ratio is not checked). This goes away if I enable and disable Keep aspect ratio or change clustering. The issue does not happen with all features I can choose for text annotation.

  • The legend is of different size than usual.

  • Could colour row annotations have a legend above/below the usual legend?

Screenshot from 2020-02-28 08-38-57

@ales-erjavec ales-erjavec force-pushed the heatmaps-grid-widget branch from d1c5962 to 8793f53 Compare March 2, 2020 15:22
@ales-erjavec ales-erjavec force-pushed the heatmaps-grid-widget branch from 8793f53 to ec36fa5 Compare March 5, 2020 15:13
@Hrovatin
Copy link
Contributor

Hrovatin commented Mar 6, 2020

It seems fine now.

@janezd janezd merged commit 6071575 into biolab:master Mar 7, 2020
@Hrovatin
Copy link
Contributor

Hrovatin commented Mar 9, 2020

I have noticed that on heatmaps that are larger than the canvas the annotations are cut from the canvas (one can not scroll far enough to reach them).
Screenshot from 2020-03-09 08-31-13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants