[ENH] OWCorrelations: Data info displayed in the status bar #4455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4455 +/- ##
==========================================
- Coverage 87.46% 83.16% -4.3%
==========================================
Files 405 268 -137
Lines 74128 53997 -20131
==========================================
- Hits 64836 44907 -19929
+ Misses 9292 9090 -202 |
VesnaT
requested changes
Feb 28, 2020
| @@ -352,12 +356,16 @@ def set_data(self, data): | |||
| cont_data = Table.from_table(Domain(cont_vars), data) | |||
| remover = Remove(Remove.RemoveConstant) | |||
| cont_data = remover(cont_data) | |||
| self.info.set_input_summary(len(data), | |||
There was a problem hiding this comment.
Info is not updated with one instance on the input.
| @@ -384,6 +392,7 @@ def commit(self): | |||
| self.Outputs.data.send(self.data) | |||
| self.Outputs.features.send(None) | |||
| self.Outputs.correlations.send(None) | |||
| self.info.set_output_summary(self.info.NoOutput) | |||
There was a problem hiding this comment.
This it not correct info when self.cont_data is None and self.data is not None.
aturanjanin
changed the title
aturanjanin
force-pushed
the
owcorrelations
branch
from
38e986a
to
cd44a14
Compare
aturanjanin
changed the title
VesnaT
reviewed
Feb 28, 2020
| @@ -402,6 +415,8 @@ def commit(self): | |||
| corr_table.name = "Correlations" | |||
|
|
|||
| self.Outputs.data.send(self.data) | |||
| self.info.set_output_summary(len(self.data), | |||
There was a problem hiding this comment.
To avoid duplicated code, I'd suggest removing upper to lines and add something like:
def commit(self):
self.Outputs.data.send(self.data)
summary = len(self.data) if self.data else self.info.NoOutput
detail = format_summary_details(self.data) if self.data else ""
self.info.set_output_summary(summary, detail)
if self.data is None or self.cont_data is None:
self.Outputs.features.send(None)
self.Outputs.correlations.send(None)
return
at the beginning of the function.
aturanjanin
force-pushed
the
owcorrelations
branch
from
cd44a14
to
1ca1db5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Input/output data info displayed in the status bar.
Includes