Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] owhierclustering: Update the scene's sceneRect #4459

Merged

Conversation

ales-erjavec
Copy link
Contributor

Issue

Fixes gh-4449

Description of changes

Set the scene's sceneRect, not just the view's. The scene's sceneRect is used when exporting the image.

Includes
  • Code changes
  • Tests
  • Documentation

Used for exported image bounds
@codecov
Copy link

codecov bot commented Feb 26, 2020

Codecov Report

Merging #4459 into master will decrease coverage by 4.33%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4459      +/-   ##
==========================================
- Coverage   87.46%   83.12%   -4.34%     
==========================================
  Files         405      268     -137     
  Lines       74135    53915   -20220     
==========================================
- Hits        64841    44819   -20022     
+ Misses       9294     9096     -198     

@janezd janezd merged commit 26d9382 into biolab:master Feb 26, 2020
@ales-erjavec ales-erjavec deleted the fixes/owhier-clust-save-image-size branch March 16, 2020 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hierarchical Clustering: saved image too big
2 participants