[ENH] OWPivotTable: Data info displayed in the status bar #4472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4472 +/- ##
=========================================
- Coverage 87.45% 83.2% -4.26%
=========================================
Files 405 268 -137
Lines 73924 54032 -19892
=========================================
- Hits 64649 44955 -19694
+ Misses 9275 9077 -198 |
VesnaT
requested changes
Mar 6, 2020
Orange/widgets/data/owpivot.py
Outdated
| @@ -821,6 +829,11 @@ def commit(self): | |||
| self.Outputs.pivot_table.send(self.pivot.pivot_table) | |||
| self.Outputs.filtered_data.send(self.get_filtered_data()) | |||
|
|
|||
| output = self.pivot.pivot_table | |||
There was a problem hiding this comment.
I'd rather consider filtered data here.
There was a problem hiding this comment.
Even though pivot table is the default output of the widget and if a user wants filtered data on the output they have to change connection afterwards?
aturanjanin
force-pushed
the
owpivottable
branch
from
abb3b11
to
972cc2c
Compare
VesnaT
requested changes
Mar 6, 2020
Orange/widgets/data/owpivot.py
Outdated
| @@ -821,6 +829,11 @@ def commit(self): | |||
| self.Outputs.pivot_table.send(self.pivot.pivot_table) | |||
| self.Outputs.filtered_data.send(self.get_filtered_data()) | |||
|
|
|||
| output = self.get_filtered_data() | |||
There was a problem hiding this comment.
Since you are saving the filtered data into a temporary variable, you can do it before self.Outputs.filtered_data.send(self.get_filtered_data()) and use it there as well, instead of creating the data twice.
aturanjanin
force-pushed
the
owpivottable
branch
from
972cc2c
to
931951f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Input/output data info displayed in the status bar.
Includes