Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Ignore missing values in density plots of projections #4525

Merged
merged 1 commit into from
Mar 17, 2020

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Mar 13, 2020

Fixes #4503.

Issue

With many missing values, density plots get ugly. Missing values should be ignored in density plots -- if they are informative, they should be transformed to a "known unknown" value.

Description of changes

Add a mask in update_density.

Includes
  • Code changes
  • Tests

@janezd janezd changed the title [ENH] Ignore missing values in density plots of projection [ENH] Ignore missing values in density plots of projections Mar 13, 2020
@codecov
Copy link

codecov bot commented Mar 13, 2020

Codecov Report

Merging #4525 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4525      +/-   ##
==========================================
+ Coverage   83.34%   83.35%   +0.01%     
==========================================
  Files         274      274              
  Lines       54906    54955      +49     
==========================================
+ Hits        45760    45810      +50     
+ Misses       9146     9145       -1

@janezd janezd force-pushed the densities-of-known branch from 1ccb2a1 to 6a6d699 Compare March 13, 2020 15:12
@VesnaT VesnaT merged commit b838a6d into biolab:master Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scatter Plot: Don't plot densities of unknown values
2 participants