Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Load Model: Use paths relative to workflow file #4534

Merged
merged 1 commit into from
Mar 20, 2020

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Mar 14, 2020

Issue

The second part of fix for #4464.

Description of changes
  • Refactor the widget to use RecentPathsWComboMixin. The code is adapted from the Distance File widget.
  • Add tests for the hitherto unchallenged widget.
Includes
  • Code changes
  • Tests

@janezd janezd force-pushed the load-model-relative branch from 5805616 to 13f45ff Compare March 14, 2020 22:41
@codecov
Copy link

codecov bot commented Mar 14, 2020

Codecov Report

Merging #4534 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4534      +/-   ##
==========================================
+ Coverage   83.36%   83.37%   +<.01%     
==========================================
  Files         279      274       -5     
  Lines       55755    54936     -819     
==========================================
- Hits        46482    45804     -678     
+ Misses       9273     9132     -141

@janezd janezd changed the title LoadModel: Use RecentPathsWComboMixin [ENH] Load Model: Use paths relative to workflow file Mar 14, 2020
@janezd janezd force-pushed the load-model-relative branch from 13f45ff to 776f525 Compare March 15, 2020 06:58
@PrimozGodec PrimozGodec merged commit e8b5c52 into biolab:master Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants