Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Paint Data: Send correct output after clicking Reset to Input #4551

Merged
merged 1 commit into from
Mar 20, 2020

Conversation

aturanjanin
Copy link
Contributor

Issue

Fixes #4514.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Mar 19, 2020

Codecov Report

Merging #4551 into master will increase coverage by 0.15%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4551      +/-   ##
==========================================
+ Coverage   83.37%   83.53%   +0.15%     
==========================================
  Files         279      276       -3     
  Lines       55779    55233     -546     
==========================================
- Hits        46507    46138     -369     
+ Misses       9272     9095     -177     

@janezd janezd self-assigned this Mar 20, 2020
@lanzagar
Copy link
Contributor

PR titles (with tags) are used to automatically compile the CHANGELOG.
Users will probably not know what changed when seeing this one in the list of changes.
Maybe something like:
[FIX] Paint Data: Send correct output after clicking Reset to Input
(or something better if anyone has a suggestion)

p.s. commit messages can be more technical as they are intended for developers.
An improvement for this one could be:
"OWPaintData: commit after reset_to_input()"

@aturanjanin
Copy link
Contributor Author

@lanzagar Thanks for your suggestions, I will fix this now.

@aturanjanin aturanjanin changed the title [FIX] OWPaintData: Reset to Input [FIX] Paint Data: Send correct output after clicking Reset to Input Mar 20, 2020
@janezd janezd merged commit 0ff63fa into biolab:master Mar 20, 2020
@aturanjanin aturanjanin deleted the paintdata branch March 30, 2020 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PaintData: Output doesn't reset when Reset to Input Data is pressed
3 participants