Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Projections keep colors after merging values #4577

Merged
merged 1 commit into from
Apr 3, 2020

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Mar 26, 2020

Issue

Fixes #4515.

I don't like it because if a variable has 100 values, which are merged into 15, they will not use a better palette for 15 colors, but instead have a HSL-based palette with 15 hues out of 100. This rather defeats the purpose of merging. No longer important after we implement #4581.

To do:

  • Improve implementation if possible. Rethink get_column which was called twice for colors and shapes, and would now be called thrice for colors. We decided, upon @VesnaT's encouragement, that the code may not be optimal, but it is more maintainable the way it is. Calling get_column_view multiple times shouldn't affect the performance because it is linear w.r.t. the number of rows.
Description of changes
Includes
  • Code changes
  • Tests
  • Documentation

@janezd janezd added the needs discussion Core developers need to discuss the issue label Mar 26, 2020
@janezd janezd changed the title Projections keep colors [ENH] Projections keep colors after merging values Mar 26, 2020
@janezd janezd removed the needs discussion Core developers need to discuss the issue label Mar 27, 2020
@janezd janezd changed the title [ENH] Projections keep colors after merging values [WIP] [ENH] Projections keep colors after merging values Mar 27, 2020
@janezd janezd force-pushed the projections-keep-colors branch from aca0d30 to 7d1fc82 Compare April 2, 2020 14:58
@codecov
Copy link

codecov bot commented Apr 2, 2020

Codecov Report

Merging #4577 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4577      +/-   ##
==========================================
+ Coverage   83.60%   83.62%   +0.02%     
==========================================
  Files         276      276              
  Lines       55372    55455      +83     
==========================================
+ Hits        46292    46375      +83     
  Misses       9080     9080              

@janezd janezd changed the title [WIP] [ENH] Projections keep colors after merging values [ENH] Projections keep colors after merging values Apr 3, 2020
@janezd janezd force-pushed the projections-keep-colors branch from 7d1fc82 to c20f1b1 Compare April 3, 2020 12:24
@robertcv robertcv merged commit 301f7d4 into biolab:master Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Header type annotation (colours) not saved correctly
2 participants