Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Heatmap: Sticky footer #4610

Merged
merged 5 commits into from
Apr 17, 2020

Conversation

ales-erjavec
Copy link
Contributor

Issue

'Heatmap' does not always hide the 'footer' shadow when it should. This seems to be style related. Observable with Fusion and Windows styles, on MacOS only if 'Show scroll bars' is 'Always' in System Preferences.

Description of changes
  • Map the footer/header scene rect to viewport coords using float precision to avoid premature rounding.
  • Accout for QRect.bottom() being one off.

Before

Screen Shot 2020-04-02 at 13 32 20

After

Screen Shot 2020-04-02 at 13 33 15

Includes
  • Code changes
  • Tests
  • Documentation

@ales-erjavec ales-erjavec changed the title [FIX] Heatmap: Sticky footer [WIP][FIX] Heatmap: Sticky footer Apr 2, 2020
@ales-erjavec ales-erjavec changed the title [WIP][FIX] Heatmap: Sticky footer [FIX] Heatmap: Sticky footer Apr 14, 2020
@janezd janezd self-assigned this Apr 17, 2020
@janezd janezd merged commit a4644bc into biolab:master Apr 17, 2020
@ales-erjavec ales-erjavec deleted the fixes/sticky-footer-rect branch August 5, 2020 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants