[FIX] Edit Domain: Fix merge values when missing data #4636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrimozGodec
changed the title
PrimozGodec
force-pushed
the
fix-edit-domain
branch
from
6a3d8c2 to
94fa21a
Compare
Codecov Report
@@ Coverage Diff @@
## master #4636 +/- ##
==========================================
- Coverage 83.64% 83.64% -0.01%
==========================================
Files 281 276 -5
Lines 56271 55470 -801
==========================================
- Hits 47070 46397 -673
+ Misses 9201 9073 -128 |
janezd
approved these changes
Apr 9, 2020
|
Now it works for me. @ajdapretnar, can you also check and then merge? |
lanzagar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #4599
Description of changes
Fixing merge data when missing values in data.
Includes