Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] owtable: output sorted data #4644

Merged
merged 1 commit into from
Jun 5, 2020

Conversation

JakaKokosar
Copy link
Member

@JakaKokosar JakaKokosar commented Apr 10, 2020

Issue

Fixes #4597

Description of changes
Includes
  • Code changes
  • Tests
  • Documentation

@JakaKokosar JakaKokosar requested a review from janezd April 10, 2020 14:23
@JakaKokosar
Copy link
Member Author

This was just a quick look at this issue. Still needs improvements and testing.

For example, data is not committed if you change the sorting order.

@janezd janezd self-assigned this Apr 16, 2020
@janezd
Copy link
Contributor

janezd commented Apr 17, 2020

This must be one of the weirdest [ENH] PRs ever: it adds functionality by removal of 33 lines, and a minor modification of a single line. Kudos.

It looks OK, just add the missing signals and tests, when you have time.

@JakaKokosar
Copy link
Member Author

Sorry for the delay. I will wrap this up today. Hopefully.

@codecov
Copy link

codecov bot commented Jun 5, 2020

Codecov Report

Merging #4644 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4644      +/-   ##
==========================================
+ Coverage   84.12%   84.14%   +0.01%     
==========================================
  Files         282      277       -5     
  Lines       57327    56480     -847     
==========================================
- Hits        48229    47524     -705     
+ Misses       9098     8956     -142     

@janezd
Copy link
Contributor

janezd commented Jun 5, 2020

Is this now still WIP or can I review and merge (if OK)?

@JakaKokosar JakaKokosar changed the title [WIP] owtable: output sorted data [ENH] owtable: output sorted data Jun 5, 2020
@JakaKokosar
Copy link
Member Author

Is this now still WIP or can I review and merge (if OK)?

I added additional tests. If CI passes I think its OK to merge.

@janezd janezd merged commit 9b46f72 into biolab:master Jun 5, 2020
@JakaKokosar JakaKokosar deleted the table_output_order branch September 2, 2020 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table widget could output sorted data
2 participants