[FIX] SOM: fix colors for numeric variables #4660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janezd
force-pushed
the
owsom-fix-binned-colors
branch
from
392659b
to
783e44e
Compare
Codecov Report
@@ Coverage Diff @@
## master #4660 +/- ##
==========================================
- Coverage 83.66% 83.65% -0.02%
==========================================
Files 280 275 -5
Lines 56322 55516 -806
==========================================
- Hits 47121 46440 -681
+ Misses 9201 9076 -125 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #4598.
SOM was incorrectly ported to new palettes: binned palette is indexed by numeric, continuous values that are put into bins by the palette. OWSOM does the binning itself and then used bin indices to index the palette.
Description of changes
Do not index the palette, index palette's
qcolorsarray.Includes