Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] SOM: fix colors for numeric variables #4660

Merged
merged 1 commit into from
Apr 17, 2020

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Apr 16, 2020

Issue

Fixes #4598.

SOM was incorrectly ported to new palettes: binned palette is indexed by numeric, continuous values that are put into bins by the palette. OWSOM does the binning itself and then used bin indices to index the palette.

Description of changes

Do not index the palette, index palette's qcolors array.

Includes
  • Code changes

@janezd janezd force-pushed the owsom-fix-binned-colors branch from 392659b to 783e44e Compare April 16, 2020 17:51
@codecov
Copy link

codecov bot commented Apr 16, 2020

Codecov Report

Merging #4660 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4660      +/-   ##
==========================================
- Coverage   83.66%   83.65%   -0.02%     
==========================================
  Files         280      275       -5     
  Lines       56322    55516     -806     
==========================================
- Hits        47121    46440     -681     
+ Misses       9201     9076     -125     

@lanzagar lanzagar merged commit 762e41f into biolab:master Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SOM on Covid data uses constant color
2 participants