Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Heatmap: Split by missing values #4686

Merged

Conversation

ales-erjavec
Copy link
Contributor

Issue

Fixes gh-4684

Description of changes
Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Apr 22, 2020

Codecov Report

Merging #4686 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4686      +/-   ##
==========================================
- Coverage   83.70%   83.69%   -0.02%     
==========================================
  Files         280      275       -5     
  Lines       56436    55644     -792     
==========================================
- Hits        47241    46571     -670     
+ Misses       9195     9073     -122     

@Hrovatin
Copy link
Contributor

This does not crash anymore. However, it is not what I expected from splitting with missing values: The missing values should be grouped in a separate N/A group (as in colour annotation legend). The behavior that was implemented by this fix can be already achieved by using Select Rows -> is defined.

@Hrovatin
Copy link
Contributor

Now it works as expected.

@ajdapretnar
Copy link
Contributor

This works well for me.

@ajdapretnar ajdapretnar merged commit 00d76da into biolab:master Apr 30, 2020
@ales-erjavec ales-erjavec deleted the fixes/heatmap-split-rows-missing branch August 5, 2020 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Heatmap row splitting (missing values?)
3 participants