Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Color widget: Add reset button #4718

Merged
merged 1 commit into from
May 15, 2020
Merged

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Apr 30, 2020

Issue

Fixes #4665.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Apr 30, 2020

Codecov Report

Merging #4718 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           master    #4718    +/-   ##
========================================
  Coverage   83.69%   83.70%            
========================================
  Files         280      275     -5     
  Lines       56420    55626   -794     
========================================
- Hits        47223    46563   -660     
+ Misses       9197     9063   -134     

@ajdapretnar ajdapretnar self-assigned this May 7, 2020
@ajdapretnar
Copy link
Contributor

This works well, just the button is fairly small compared to the widget.

@janezd
Copy link
Contributor Author

janezd commented May 8, 2020

Indeed it is, but Reset button is supposed to be small. :)
(It's also easier to implement it this way.)

@ajdapretnar ajdapretnar merged commit 1872481 into biolab:master May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Color: No way to reset to default
2 participants