Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Test and Score: Improve data errors #4738

Merged
merged 1 commit into from
May 8, 2020

Conversation

PrimozGodec
Copy link
Contributor

@PrimozGodec PrimozGodec commented May 5, 2020

Issue
  • Fixes Test & Score: better warning/error when no features on input #4734
  • Currently, we only check that class_var has more than 1 class value, but it can happen that this condition is valid but there is only one class present in Y. I think it is better not to handle this case and show an error. The same is done by any model widget in Orange. Another argument to prevent this option is since learners do not support only one class in data. I hope my thinking is ok and that I didn't overlook any special case.
Description of changes
  • Added error for no features
  • Showing error when only one class in data - even class_var.values have more.
  • Errors cleanup
Includes
  • Code changes
  • Tests

@PrimozGodec PrimozGodec force-pushed the test-and-score-warning branch from 137f2d8 to c1a4679 Compare May 5, 2020 13:08
@PrimozGodec PrimozGodec changed the title [WIP][FIX] TestAndScore: Modify data errors [FIX] TestAndScore: Modify data errors May 5, 2020
@PrimozGodec PrimozGodec force-pushed the test-and-score-warning branch from c1a4679 to 76d0b39 Compare May 5, 2020 14:06
@codecov
Copy link

codecov bot commented May 5, 2020

Codecov Report

Merging #4738 into master will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4738      +/-   ##
==========================================
+ Coverage   83.69%   83.78%   +0.09%     
==========================================
  Files         275      275              
  Lines       55620    55688      +68     
==========================================
+ Hits        46551    46660     +109     
+ Misses       9069     9028      -41     

@lanzagar lanzagar changed the title [FIX] TestAndScore: Modify data errors [FIX] Test and Score: Improve data errors May 8, 2020
@PrimozGodec PrimozGodec force-pushed the test-and-score-warning branch from 76d0b39 to 74c01f5 Compare May 8, 2020 11:59
@lanzagar lanzagar merged commit 67ed8aa into biolab:master May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test & Score: better warning/error when no features on input
2 participants