Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Feature Statistics: Fix wrong or even crashing selections #4741

Merged
merged 1 commit into from
May 15, 2020

Conversation

janezd
Copy link
Contributor

@janezd janezd commented May 5, 2020

Issue

Supposedly fixes #4683.

Description of changes

Selection was stored as list of indices and wasn't used in context matching. This resulted in wrong selection when columns were reordered or even crashes when their number was reduced.

Includes
  • Code changes
  • Tests

@codecov
Copy link

codecov bot commented May 5, 2020

Codecov Report

Merging #4741 into master will decrease coverage by 0.00%.
The diff coverage is 95.65%.

@@            Coverage Diff             @@
##           master    #4741      +/-   ##
==========================================
- Coverage   83.82%   83.82%   -0.01%     
==========================================
  Files         280      276       -4     
  Lines       56534    55830     -704     
==========================================
- Hits        47388    46797     -591     
+ Misses       9146     9033     -113     

@janezd janezd assigned janezd and markotoplak and unassigned janezd May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature statistics error
2 participants