[FIX] OWContinuize: Fix treatment of continuous features. #4806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thocevar
commented
May 22, 2020
| @@ -242,7 +242,7 @@ def needs_dist(var, mtreat, ctreat): | |||
| for var, needs_dist in zip(domain.attributes, attr_needs_dist)] | |||
| newclass = [continuize_var(var, | |||
| next(dist_iter) if needs_dist else None, | |||
| class_treatment, Continuize.Remove) | |||
There was a problem hiding this comment.
I can't find a reason for this Continuize.Remove.
There was a problem hiding this comment.
It doesn't hurt to give the value explicitly, either...
Codecov Report
@@ Coverage Diff @@
## master #4806 +/- ##
==========================================
- Coverage 83.99% 83.98% -0.02%
==========================================
Files 281 276 -5
Lines 56877 56070 -807
==========================================
- Hits 47775 47088 -687
+ Misses 9102 8982 -120 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #4801. Probably caused by #4466.
Description of changes
Continuous treatments were identified in two ways, by enums
Continuizeand a newly introducedNormalize. However,Continuize.Leavedoes not match withNormalize.Leave, which was the source of problems.All continuous treatments are now defined by
OWContinuize.Normalize.Includes