Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Feature statistics report #4812

Merged
merged 1 commit into from
Jun 10, 2020
Merged

Conversation

PrimozGodec
Copy link
Contributor

@PrimozGodec PrimozGodec commented May 25, 2020

Issue

Implements #4773

Description of changes

Implement report for feature statistics

It can be merged when biolab/orange-widget-base#68 is merged and the orange widget base is released.

Includes
  • Code changes
  • Tests

@codecov
Copy link

codecov bot commented May 25, 2020

Codecov Report

Merging #4812 into master will increase coverage by 0.15%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4812      +/-   ##
==========================================
+ Coverage   83.86%   84.02%   +0.15%     
==========================================
  Files         281      276       -5     
  Lines       56804    56086     -718     
==========================================
- Hits        47638    47125     -513     
+ Misses       9166     8961     -205     

@janezd
Copy link
Contributor

janezd commented Jun 5, 2020

I get this:

Screenshot 2020-06-05 at 20 49 57

I suppose the problem (large icons) is in biolab/orange-widget-base#68, not here?

Can we now merge this? Do I remember correctly that nothing will go wrong for as long as we remember to release orange-widget-base before/when releasing Orange?

@PrimozGodec PrimozGodec changed the title [NO-MERGE][ENH] Feature statistics report [ENH] Feature statistics report Jun 9, 2020
@PrimozGodec
Copy link
Contributor Author

PrimozGodec commented Jun 9, 2020

It can be merged. Ales prepared a fix for your issue with the icons. Can you check if biolab/orange-widget-base#72 solves the issue?

@janezd janezd merged commit adad6e2 into biolab:master Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants