Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Distributions: change Histogram Data output #4832

Merged
merged 4 commits into from
Jun 5, 2020

Conversation

thocevar
Copy link
Contributor

Issue

Fixes #4813

Description of changes

Data output (annotated data) is always active. Before it was active only when something was selected. There was an explicit test that the output is empty after loading the data (no idea why).

Histogram data output now contains the bin and frequency data that is displayed in the widget. I don't know what was its purpose before (it was almost the same as Data).

Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented May 29, 2020

Codecov Report

Merging #4832 into master will increase coverage by 0.05%.
The diff coverage is 92.59%.

@@            Coverage Diff             @@
##           master    #4832      +/-   ##
==========================================
+ Coverage   84.02%   84.07%   +0.05%     
==========================================
  Files         281      277       -4     
  Lines       56898    56510     -388     
==========================================
- Hits        47808    47511     -297     
+ Misses       9090     8999      -91     

@ajdapretnar
Copy link
Contributor

ajdapretnar commented Jun 1, 2020

This drastically changes the Histogram output. Before it output the data with the selected variable split into bins as set in the widget. --> Btw, this is probably also why it didn't output anything for discrete variables.

I think Data could always be on the output (that is the way elsewhere).

@thocevar thocevar added the needs discussion Core developers need to discuss the issue label Jun 1, 2020
@janezd janezd removed their assignment Jun 5, 2020
@thocevar thocevar removed the needs discussion Core developers need to discuss the issue label Jun 5, 2020
@thocevar
Copy link
Contributor Author

thocevar commented Jun 5, 2020

Information about bins (for distributions of continuous variables) is now included in the Data output besides the selection indicator.

@janezd
Copy link
Contributor

janezd commented Jun 5, 2020

I wanted to add a commit with updated documentation, but then saw that the current documentation is from the period shortly after the elves departed from Middle Earth and needs to be entirely rewritten and rescreenshot.

We should organize an "update the docs" sprint some day.

@janezd janezd merged commit 2433cc2 into biolab:master Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Distribution Widgets passes no data on ist output connections for class variables.
3 participants