Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] get_unique_names: Handle more independent names #4866

Merged
merged 1 commit into from
Jun 26, 2020

Conversation

PrimozGodec
Copy link
Contributor

Issue

get_unique_names always returns names with all the same indices e.g. If we have an existing names: ['foo', 'baz', 'baz (1)'] and we want to add ['foo', 'baz'], new names will be ['foo (2)', 'baz (2)'].

Description of changes

With this PR we are adding the possibility handle names which are independent. If the user sets equal_numbers=False. She/he will now get ['foo (1)', 'baz (2)'].

Includes
  • Code changes
  • Tests
  • Documentation

@PrimozGodec PrimozGodec force-pushed the ge-unique-nonequal-numbers branch from 25de34e to cebb02f Compare June 22, 2020 13:21
@PrimozGodec PrimozGodec force-pushed the ge-unique-nonequal-numbers branch from cebb02f to dc24036 Compare June 23, 2020 10:08
@codecov
Copy link

codecov bot commented Jun 23, 2020

Codecov Report

Merging #4866 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4866      +/-   ##
==========================================
- Coverage   84.20%   84.18%   -0.03%     
==========================================
  Files         282      277       -5     
  Lines       57331    56506     -825     
==========================================
- Hits        48276    47567     -709     
+ Misses       9055     8939     -116     

@janezd janezd self-assigned this Jun 25, 2020
@janezd janezd merged commit 5031956 into biolab:master Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants