[FIX] Re-add TupleList to DiscreteVariable #4879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrimozGodec
force-pushed
the
readd-tuple-list
branch
from
f34aae8
to
1fd9d76
Compare
Codecov Report
@@ Coverage Diff @@
## master #4879 +/- ##
==========================================
- Coverage 84.17% 84.14% -0.03%
==========================================
Files 282 277 -5
Lines 57464 56637 -827
==========================================
- Hits 48368 47657 -711
+ Misses 9096 8980 -116 |
PrimozGodec
changed the title
lanzagar
reviewed
Jul 3, 2020
Orange/data/variable.py
Outdated
| @@ -622,7 +625,7 @@ def __init__( | |||
| *, sparse=False | |||
| ): | |||
| """ Construct a discrete variable descriptor with the given values. """ | |||
| values = tuple(values) # some people (including me) pass a generator | |||
| values = TupleList(values) # some people pass a generator | |||
There was a problem hiding this comment.
Correct me if I'm wrong, but I think this can remain just tuple (for creating new instances) as long as the above is there for unpickling of saved older classes.
There was a problem hiding this comment.
You are right :)
PrimozGodec
force-pushed
the
readd-tuple-list
branch
from
1fd9d76
to
6722145
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #4875
Description of changes
Re-add TupleList and write test
Includes