[ENH] Rank widget computation in a separate thread #4908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrimozGodec
force-pushed
the
rank-concurent
branch
3 times, most recently
from
f44a0bc
to
9adddfa
Compare
Codecov Report
@@ Coverage Diff @@
## master #4908 +/- ##
=======================================
Coverage 84.62% 84.62%
=======================================
Files 285 285
Lines 59427 59462 +35
=======================================
+ Hits 50288 50319 +31
- Misses 9139 9143 +4 |
PrimozGodec
force-pushed
the
rank-concurent
branch
from
9adddfa
to
b28e0be
Compare
|
@PrimozGodec, please make sure that run does use any attributes from the object, because they can now be set independently (connecting a new data set to it could do that). As it is now, run() calls get_scorer_score and get_method_scores which both use self.data. To be safe, could you make run() and all the methods it calls static. |
PrimozGodec
force-pushed
the
rank-concurent
branch
2 times, most recently
from
a65ad60
to
a73c5e2
Compare
|
@markotoplak I changed now such that problematic methods get data now and are static. lru_cache uses hashes of arguments to store results. |
PrimozGodec
force-pushed
the
rank-concurent
branch
8 times, most recently
from
e343016
to
194f4a8
Compare
|
Documentation test will pass after merging this PR #5010 I hope it is working now correctly. |
PrimozGodec
force-pushed
the
rank-concurent
branch
from
194f4a8
to
e81fabd
Compare
Because it timeouted once. I decreased duration of 3 secs to 1 sec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Rank widget blocks Orange while computing on a larger dataset
Description of changes
Use
ConcurrentWidgetMixinin the rank widget.Includes