Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] owcsvimport: Fix a type error in _open for zip archive #4921

Merged
merged 2 commits into from
Jul 30, 2020

Conversation

ales-erjavec
Copy link
Contributor

@ales-erjavec ales-erjavec commented Jul 24, 2020

Issue

CSVFileImport intends to but fails to read single member zip archive (raises a TypeError).

(e.g precip.csv.zip)

Description of changes

Fix a type error.

Includes
  • Code changes
  • Tests
  • Documentation

@ales-erjavec ales-erjavec force-pushed the fixes/owcsvimport-open-zip branch from e4ca65f to 73b9048 Compare July 24, 2020 14:33
@codecov
Copy link

codecov bot commented Jul 24, 2020

Codecov Report

Merging #4921 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4921      +/-   ##
==========================================
+ Coverage   84.10%   84.12%   +0.02%     
==========================================
  Files         278      278              
  Lines       56994    56999       +5     
==========================================
+ Hits        47934    47951      +17     
+ Misses       9060     9048      -12     

@janezd janezd merged commit 21b6b45 into biolab:master Jul 30, 2020
@ales-erjavec ales-erjavec deleted the fixes/owcsvimport-open-zip branch August 5, 2020 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants