Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] ProjectionWidgetMixinTests: set shape attribute only when discrete var available #4946

Merged
merged 1 commit into from
Sep 4, 2020

Conversation

PrimozGodec
Copy link
Contributor

@PrimozGodec PrimozGodec commented Aug 20, 2020

Issue

Some projection widgets (e.g. Annotator in Bioinformatics addon) have test data without Discrete variables so attr_shape cannot be set to any variable.

Description of changes

Set attr_shape to first Discrete variable in the domain if exists.

Includes
  • Code changes
  • Tests
  • Documentation

@PrimozGodec PrimozGodec changed the title [WIP] [FIX] ProjectionWidgetMixinTests: set shape attribute only when discrete var available [FIX] ProjectionWidgetMixinTests: set shape attribute only when discrete var available Aug 20, 2020
@PrimozGodec PrimozGodec requested a review from VesnaT August 20, 2020 09:42
@janezd janezd self-assigned this Sep 3, 2020
@janezd janezd merged commit 1895c41 into biolab:master Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants