Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Edit Domain: Multiple item rename/merge #4949

Merged
merged 4 commits into from
Sep 4, 2020

Conversation

ales-erjavec
Copy link
Contributor

Issue

Ref gh-4914

Enable merging by inline simultaneous multiple item rename.

Description of changes
  • Re-enable inline multiple item edit
  • Move the functionality to the delegate an make it behave the same for edits triggered by platform edit key (Enter/Return or F2), is also available via context menu.
Includes
  • Code changes
  • Tests
  • Documentation

@ales-erjavec ales-erjavec force-pushed the fixes/oweditdomain-merge branch 3 times, most recently from c5f8021 to d2ca122 Compare August 28, 2020 08:48
@codecov
Copy link

codecov bot commented Aug 28, 2020

Codecov Report

Merging #4949 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4949      +/-   ##
==========================================
+ Coverage   84.49%   84.50%   +0.01%     
==========================================
  Files         283      283              
  Lines       58234    58298      +64     
==========================================
+ Hits        49204    49267      +63     
- Misses       9030     9031       +1     

@ales-erjavec ales-erjavec changed the title [FIX] Fixes/oweditdomain merge [FIX] Edit Domain: Multiple item rename/merge Aug 28, 2020
@ales-erjavec ales-erjavec force-pushed the fixes/oweditdomain-merge branch from d2ca122 to f7129e3 Compare August 28, 2020 14:18
@ales-erjavec ales-erjavec force-pushed the fixes/oweditdomain-merge branch from f7129e3 to c45e0a3 Compare September 4, 2020 09:54
@thocevar thocevar merged commit 9f25898 into biolab:master Sep 4, 2020
@ales-erjavec ales-erjavec deleted the fixes/oweditdomain-merge branch January 28, 2021 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants